Skip to content

Pass API server address to HelmController @jip149 #13023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Pass API server address to HelmController @jip149 #13023

wants to merge 2 commits into from
+7 −6

Conversation

@jip149
Copy link

@jip149 jip149 commented Oct 3, 2025

Proposed Changes

HelmController fails on bootstrap charts when the API server is not listening on port 127.0.0.1:6443.

A PR has been submitted to fix this issue: k3s-io/helm-controller#288

The PR changes the chart.Register function signature, and this change needs to be reflected in k3s.

This will also avoid breaking bootstrap charts if some day k3s is updated not to forcefully listen on 127.0.0.1

Types of Changes

This basically just adds an argument to function call.

Verification

curl -sfL https://get.k3s.io | sh -s - server --cluster-cidr=2001:db8:42::/56 --service-cidr=2001:db8:43::/112 --flannel-ipv6-masq
kubectl apply -f - <<EOF
apiVersion: v1
kind: Namespace
metadata:
  name: web
---
apiVersion: helm.cattle.io/v1
kind: HelmChart
metadata:
  name: apache
  namespace: kube-system
spec:
  repo: https://charts.bitnami.com/bitnami
  chart: apache
  bootstrap: true
  targetNamespace: web
  valuesContent: |-
    service:
      type: ClusterIP
    ingress:
      enabled: true
      hostname: www.example.com
    metrics:
      enabled: true
EOF

Chart should install without error.

Testing

An issue is open #12991

Linked Issues

See discussion here #12947

User-Facing Change

NONE

jip149 added 2 commits October 3, 2025 10:29
@jip149
Remember default API server bind address
9c2aefb 
The default API server bind address was determined when starting the API
server but was not stored anywhere.

It can be useful to get access to the address later on, so we instead
store the default value as if it had been given in the configuration.
@jip149
Pass API server address to HelmController
d550b67 
HelmController needs API server address for bootstrap charts
@jip149 jip149 requested a review from a team as a code owner October 3, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jip149